Skip to content

[monitor] Extend version range for psutil to include 7.x - #40459

Merged
Leighton Chen (lzchen) merged 3 commits into
Azure:mainfrom
bartvanandel:fix/allow-psutil-7.x
Apr 22, 2025
Merged

[monitor] Extend version range for psutil to include 7.x#40459
Leighton Chen (lzchen) merged 3 commits into
Azure:mainfrom
bartvanandel:fix/allow-psutil-7.x

Conversation

@bartvanandel

@bartvanandel Bart van Andel (bartvanandel) commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Extend the supported version range of psutil to include version 7.x. The only relevant breaking change (dropped support for Python 2.7) doesn't affect azure-sdk-for-python, which already requires Python 3.8+.

See https://github.com/giampaolo/psutil/blob/master/HISTORY.rst#700

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter labels Apr 10, 2025
@github-actions

github-actions Bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution Bart van Andel (@bartvanandel)! We will review the pull request and get back to you soon.

@azure-sdk

Azure SDK Bot (azure-sdk) commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@bartvanandel Bart van Andel (bartvanandel) changed the title Extend version range for psutil to include 7.x [monitor] Extend version range for psutil to include 7.x Apr 10, 2025
@bartvanandel

Bart van Andel (bartvanandel) commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

Should I just check off the tasks that don't really apply? A similar PR (#39354) was merged a while ago, having none of them checked.

@lzchen

Leighton Chen (lzchen) commented Apr 12, 2025

Copy link
Copy Markdown
Member

Bart van Andel (@bartvanandel)

Please rebase to the latest main to fix builds.

@bartvanandel

Bart van Andel (bartvanandel) commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Please rebase to the latest main to fix builds.

Leighton Chen (@lzchen) Done

lzchen
Leighton Chen (lzchen) approved these changes Apr 14, 2025
View reviewed changes

@lzchen Leighton Chen (lzchen) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a CHANGELOG entry to indicate this change please.

@bartvanandel

Bart van Andel (bartvanandel) commented Apr 14, 2025

Copy link
Copy Markdown
Contributor Author

LGTM. Please add a CHANGELOG entry to indicate this change please.

The same thing was done a while ago for this same package, there's no entry in CHANGELOG for that. I don't see any other such changes mentioned, can you suggest a template string to add? Fine by me as well if you change it in this PR directly, that will probably save both of us some time.

@bartvanandel

Bart van Andel (bartvanandel) commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Millennity"

@lzchen

Leighton Chen (lzchen) commented Apr 22, 2025

Copy link
Copy Markdown
Member

Bart van Andel (@bartvanandel)

Apologies for the delay, could you rebase with main to try to fix the build issues?

@bartvanandel
fix(deps): allow psutil 7.x
fe2311e 
Support for Python 2.7 was dropped in psutil 7, but
azure-sdk-for-python requires Python 3.8+ anyway.
@bartvanandel

Bart van Andel (bartvanandel) commented Apr 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Leighton Chen (@lzchen) Done, checks are currently running.

edit: whoops, accidentally removed the changes to CHANGELOG, I've re-added them just now

@bartvanandel

Bart van Andel (bartvanandel) commented Apr 22, 2025

Copy link
Copy Markdown
Contributor Author

Checks fail only because psutil isn't recognized as a valid word in the CHANGELOG. I suppose that shouldn't be a blocker.

@lzchen
Leighton Chen (lzchen) merged commit 1d19d94 into Azure:main Apr 22, 2025
@bartvanandel
Bart van Andel (bartvanandel) deleted the fix/allow-psutil-7.x branch April 22, 2025 22:05
Rena (cRui861) pushed a commit that referenced this pull request May 14, 2025
@bartvanandel Rena Chen
[monitor] Extend version range for psutil to include 7.x (#40459)
3ae35dc
@jeremydvoss Jeremy Voss (jeremydvoss) mentioned this pull request May 29, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeremydvoss Jeremy Voss (jeremydvoss) jeremydvoss approved these changes
@lzchen Leighton Chen (lzchen) lzchen approved these changes
@hectorhdzg Hector Hernandez (hectorhdzg) Awaiting requested review from hectorhdzg hectorhdzg is a code owner

Assignees

No one assigned

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bartvanandel @azure-sdk @lzchen @jeremydvoss